chore: release 0.1.8 by siy · Pull Request #9 · siy/java-peglib

siy · 2025-12-31T10:24:44Z

Summary

Add furthestPos/furthestFailure tracking to both AST and CST generated parsers
Replace null checks with Option<T> in CST parser generator for JBCT compliance
Fix infinite recursion bug in AST parser when whitespace rule uses * quantifier
Add 3 new tests for error position reporting

Problem

When parsing fails, PEG parsers backtrack trying alternatives. Previously, errors were often reported at position 1:1 instead of where the actual failure occurred. This made debugging grammar issues difficult.

Solution

Track the farthest position where parsing failed, along with what was expected. Report errors at this position instead of wherever backtracking ended up.

Test plan

All 308 tests pass
New tests verify error is reported at farthest position, not 1:1
No regression in existing functionality

🤖 Generated with Claude Code

Summary by CodeRabbit

New Features
- Improved error-position tracking and richer parser diagnostics for clearer, more accurate error locations.
- Java 25 grammar updates with tighter keyword/token handling to reduce parsing ambiguities.
Bug Fixes
- Fixed farthest-failure tracking and related parser error-reporting issues.
Tests
- Added extensive tests validating error-position reporting and diagnostic formatting for generated parsers, plus a new test resource.
Documentation
- Updated CHANGELOG with [0.1.8] entry dated 2025-12-31.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

- Add furthestPos/furthestFailure tracking to AST and CST generated parsers - Replace null checks with Option<T> in CST parser generator - Fix infinite recursion in AST parser whitespace rule generation - Add 3 tests for error position reporting (305 → 308 tests) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

coderabbitai · 2025-12-31T10:24:52Z

📝 Walkthrough

Walkthrough

Adds furthest-failure tracking and aggregated expected-token reporting to generated parsers; refactors CST/parse-result types to use Option-wrapped nodes/locations; introduces error-position tests and updates Java25 grammar with cut/lookahead/tokenization improvements.

Changes

Cohort / File(s)	Summary
Changelog `CHANGELOG.md`	Added `[0.1.8] - 2025-12-31` entry documenting Java 25 grammar sync, furthest-failure tracking, parser fixes, and new error-position tests.
Parser generator core `src/main/java/org/pragmatica/peg/generator/ParserGenerator.java`	Added `inWhitespaceRuleGeneration` flag; added furthest-failure tracking fields and `trackFailure` emission; conditional whitespace-skip emission; switched some `result.value.orElse(...)` to `result.value.or(null)`; pervasive codegen changes to propagate failure tracking and diagnostics.
CST / Parse result types (generated shapes) `src/main/java/org/pragmatica/peg/generator/...`	`ParseResultWithDiagnostics` and `CstParseResult` now use `Option<CstNode>` and Option-wrapped locations/messages instead of nullable nodes/locations; factory methods and presence checks updated to `isPresent()`; diagnostics plumbing adjusted.
Tests — parser error positions `src/test/java/org/pragmatica/peg/generator/ParserGeneratorTest.java`	Added runtime compile/load helper and tests verifying furthest-position error reporting for AST and CST parsers across BASIC/ADVANCED modes; imports for dynamic compilation/URLClassLoader added.
Java25 grammar example `src/test/java/org/pragmatica/peg/examples/Java25GrammarExample.java`	Large grammar updates: added cut (`^`) operators across many rules, introduced keyword-specific KW rules and lookaheads, tightened keyword/identifier boundaries, improved lookahead for Primary/TypeExpr/QualifiedName, and many production adjustments to reduce backtracking.
Test resources `src/test/resources/ParseError.java`	Added test resource `test.ParseError` containing valid and intentionally broken methods to exercise parser error reporting.
Build `pom.xml`	Bumped project version from `0.1.7` to `0.1.8`.

Sequence Diagram(s)

sequenceDiagram
    participant Caller as Caller
    participant Parser as GeneratedParser
    participant Context as ParseContext
    participant Diagnostics as DiagnosticsBuilder
    participant Result as ParseResult

    Caller->>Parser: parse(input)
    activate Parser

    Parser->>Context: init(furthestPos = -1, furthestExpected = empty)
    loop try expressions / alternatives
        Parser->>Context: tryExpression(expr)
        alt success
            Context->>Parser: return success(node)
        else failure
            Parser->>Context: trackFailure(currentPos, expectedMsg)
            Context->>Context: update furthestPos / furthestExpected
        end
    end

    alt parse succeeded
        Parser->>Result: success(Option.some(node))
    else parse failed
        Context->>Diagnostics: buildDiagnostics(furthestPos, furthestExpected)
        Diagnostics->>Result: withErrors(Option.none(), diagnostics)
    end

    Result-->>Caller: return parse result (Option node + diagnostics)
    deactivate Parser

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Possibly related PRs

Release 0.1.7 #8: Modifies parse result types to use Option<T> for CST nodes and updates related APIs — strongly related to the Option-based result refactor here.

Poem

🐰
I hopped through grammar, sharp and neat,
Chased the furthest fail with tiny feet.
Wrapped nodes in Option, diagnostics bright,
Cut backtrack paths and fixed the sight.
Now errors point true — what a delight!

Pre-merge checks

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The PR title 'chore: release 0.1.8' does not accurately reflect the primary changes, which are significant: adding farthest-failure tracking, fixing an infinite recursion bug, and replacing null checks with Option. The actual PR objective (from source branch and description) is 'fix: report parse errors at farthest failure position', not a routine release.	Update the PR title to reflect the main objective: 'fix: report parse errors at farthest failure position' or similar, and update version bump as a secondary change in release notes.
Docstring Coverage	⚠️ Warning	Docstring coverage is 5.56% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c3814aa and e683ec9.

📒 Files selected for processing (2)

CHANGELOG.md
pom.xml

✅ Files skipped from review due to trivial changes (1)

pom.xml

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/main/java/org/pragmatica/peg/parser/**/*.java : Implement both CST (Concrete Syntax Tree) and AST (Abstract Syntax Tree) output modes for parsers

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/main/java/org/pragmatica/peg/error/**/*.java : Support configurable error recovery with three strategies: NONE (fail immediately), BASIC (report error with context), ADVANCED (continue parsing and collect multiple errors)

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/main/java/org/pragmatica/peg/generator/**/*.java : Generated parsers should only depend on pragmatica-lite:core, with optional ErrorReporting enum (BASIC/ADVANCED) for Rust-style diagnostics

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/main/java/org/pragmatica/peg/grammar/**/*.java : Implement grammar syntax compatible with cpp-peglib, including operators (e1 e2, e1/e2, e*, e+, e?, &e, !e), extensions (< >, ~e, 'text'i, $name, ^), and directives (%whitespace)

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/test/java/org/pragmatica/peg/**/*.java : Test coverage should include: grammar parser (17), parsing engine (29), actions (6), generator (18), internal types (24), examples (135), and trivia handling (19)

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/main/java/org/pragmatica/peg/error/Diagnostic.java : Implement Rust-style diagnostic formatting with error location (file:line:column), context lines, and help messages for error recovery output

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/main/java/org/pragmatica/peg/**/*.java : Use Result/Option types from pragmatica-lite for return values instead of exceptions or null

📚 Learning: 2025-12-30T12:39:57.084Z

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/main/java/org/pragmatica/peg/grammar/**/*.java : Implement grammar syntax compatible with cpp-peglib, including operators (e1 e2, e1/e2, e*, e+, e?, &e, !e), extensions (< >, ~e, 'text'i, $name, ^), and directives (%whitespace)

Applied to files:

CHANGELOG.md

🔇 Additional comments (1)

CHANGELOG.md (1)

8-32: LGTM — comprehensive and accurate release notes.

The v0.1.8 entry properly captures all major changes from the PR:

Farthest failure tracking (lines 23–27): Accurately describes both AST/CST parser enhancements, Option refactoring, and the infinite-recursion fix.

Error position tests (lines 31–32): Test count increase (305→308) aligns with PR objectives.

Java 25 grammar improvements (lines 12–19): Specific technical details (cut operators, keyword helpers, token boundaries, lookaheads) are well-documented.

Format and structure follow Keep a Changelog conventions consistently with prior versions.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/test/java/org/pragmatica/peg/generator/ParserGeneratorTest.java (1)
440-472: Consider cleanup of temporary directories.

The helper method creates temporary directories but doesn't explicitly clean them up. While the OS will eventually clean up temp directories, consider using @TempDir JUnit annotation or explicitly deleting the directory after tests to avoid accumulation during test runs.
Optional cleanup approach

Use JUnit 5's @TempDir annotation:
@TempDir
Path tempDir;

private Object compileAndInstantiate(String source, String className) throws Exception {
    // Remove: var tempDir = Files.createTempDirectory("peglib-test");
    var packagePath = className.substring(0, className.lastIndexOf('.')).replace('.', '/');
    // ... rest of implementation
}
Alternatively, add explicit cleanup in a try-finally block within the method.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bfba16c and 7c7edcd.

📒 Files selected for processing (3)

CHANGELOG.md
src/main/java/org/pragmatica/peg/generator/ParserGenerator.java
src/test/java/org/pragmatica/peg/generator/ParserGeneratorTest.java

🧰 Additional context used

📓 Path-based instructions (5)

**/*.java

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.java: Use sealed interfaces for abstract types with fixed implementations (Expression, ParseResult, CstNode, AstNode, Trivia, ParseError)
Use record classes for immutable data types (Rule, Grammar, SourceLocation, SourceSpan, ParserConfig)

Files:

src/main/java/org/pragmatica/peg/generator/ParserGenerator.java
src/test/java/org/pragmatica/peg/generator/ParserGeneratorTest.java

src/main/java/org/pragmatica/peg/**/*.java

📄 CodeRabbit inference engine (CLAUDE.md)

src/main/java/org/pragmatica/peg/**/*.java: Package code under org.pragmatica.peg namespace
Use Result/Option types from pragmatica-lite for return values instead of exceptions or null

Files:

src/main/java/org/pragmatica/peg/generator/ParserGenerator.java

src/main/java/org/pragmatica/peg/{parser,generator}/**/*.java

📄 CodeRabbit inference engine (CLAUDE.md)

Support both runtime compilation (JDK Compiler API with full Java support) and source generation (single self-contained Java file) modes

Files:

src/main/java/org/pragmatica/peg/generator/ParserGenerator.java

src/main/java/org/pragmatica/peg/generator/**/*.java

📄 CodeRabbit inference engine (CLAUDE.md)

Generated parsers should only depend on pragmatica-lite:core, with optional ErrorReporting enum (BASIC/ADVANCED) for Rust-style diagnostics

Files:

src/main/java/org/pragmatica/peg/generator/ParserGenerator.java

src/test/java/org/pragmatica/peg/**/*.java

📄 CodeRabbit inference engine (CLAUDE.md)

Test coverage should include: grammar parser (17), parsing engine (29), actions (6), generator (18), internal types (24), examples (135), and trivia handling (19)

Files:

src/test/java/org/pragmatica/peg/generator/ParserGeneratorTest.java

🧠 Learnings (13)

📓 Common learnings

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/main/java/org/pragmatica/peg/error/**/*.java : Support configurable error recovery with three strategies: NONE (fail immediately), BASIC (report error with context), ADVANCED (continue parsing and collect multiple errors)

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/main/java/org/pragmatica/peg/parser/**/*.java : Implement both CST (Concrete Syntax Tree) and AST (Abstract Syntax Tree) output modes for parsers

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/main/java/org/pragmatica/peg/generator/**/*.java : Generated parsers should only depend on pragmatica-lite:core, with optional ErrorReporting enum (BASIC/ADVANCED) for Rust-style diagnostics

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/main/java/org/pragmatica/peg/grammar/**/*.java : Implement grammar syntax compatible with cpp-peglib, including operators (e1 e2, e1/e2, e*, e+, e?, &e, !e), extensions (< >, ~e, 'text'i, $name, ^), and directives (%whitespace)

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/test/java/org/pragmatica/peg/**/*.java : Test coverage should include: grammar parser (17), parsing engine (29), actions (6), generator (18), internal types (24), examples (135), and trivia handling (19)

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/main/java/org/pragmatica/peg/**/*.java : Use Result/Option types from pragmatica-lite for return values instead of exceptions or null

📚 Learning: 2025-12-30T12:39:57.084Z

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/main/java/org/pragmatica/peg/generator/**/*.java : Generated parsers should only depend on pragmatica-lite:core, with optional ErrorReporting enum (BASIC/ADVANCED) for Rust-style diagnostics

Applied to files:

src/main/java/org/pragmatica/peg/generator/ParserGenerator.java
src/test/java/org/pragmatica/peg/generator/ParserGeneratorTest.java

📚 Learning: 2025-12-30T12:39:57.084Z

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/main/java/org/pragmatica/peg/parser/**/*.java : Implement both CST (Concrete Syntax Tree) and AST (Abstract Syntax Tree) output modes for parsers

Applied to files:

src/main/java/org/pragmatica/peg/generator/ParserGenerator.java
src/test/java/org/pragmatica/peg/generator/ParserGeneratorTest.java

📚 Learning: 2025-12-30T12:39:57.084Z

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/main/java/org/pragmatica/peg/grammar/**/*.java : Implement grammar syntax compatible with cpp-peglib, including operators (e1 e2, e1/e2, e*, e+, e?, &e, !e), extensions (< >, ~e, 'text'i, $name, ^), and directives (%whitespace)

Applied to files:

src/main/java/org/pragmatica/peg/generator/ParserGenerator.java
src/test/java/org/pragmatica/peg/generator/ParserGeneratorTest.java

📚 Learning: 2025-12-30T12:39:57.084Z

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/main/java/org/pragmatica/peg/{parser,generator}/**/*.java : Support both runtime compilation (JDK Compiler API with full Java support) and source generation (single self-contained Java file) modes

Applied to files:

src/main/java/org/pragmatica/peg/generator/ParserGenerator.java
src/test/java/org/pragmatica/peg/generator/ParserGeneratorTest.java

📚 Learning: 2025-12-30T12:39:57.084Z

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/main/java/org/pragmatica/peg/tree/**/*.java : Group whitespace and comments as Trivia nodes (Trivia.Whitespace, Trivia.LineComment, Trivia.BlockComment) for lossless CST

Applied to files:

src/main/java/org/pragmatica/peg/generator/ParserGenerator.java

📚 Learning: 2025-12-30T12:39:57.084Z

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/main/java/org/pragmatica/peg/**/*.java : Use Result/Option types from pragmatica-lite for return values instead of exceptions or null

Applied to files:

src/main/java/org/pragmatica/peg/generator/ParserGenerator.java
src/test/java/org/pragmatica/peg/generator/ParserGeneratorTest.java

📚 Learning: 2025-12-30T12:39:57.084Z

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/main/java/org/pragmatica/peg/**/*.java : Package code under org.pragmatica.peg namespace

Applied to files:

src/main/java/org/pragmatica/peg/generator/ParserGenerator.java
src/test/java/org/pragmatica/peg/generator/ParserGeneratorTest.java

📚 Learning: 2025-12-30T12:39:57.084Z

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/test/java/org/pragmatica/peg/**/*.java : Test coverage should include: grammar parser (17), parsing engine (29), actions (6), generator (18), internal types (24), examples (135), and trivia handling (19)

Applied to files:

src/main/java/org/pragmatica/peg/generator/ParserGenerator.java
src/test/java/org/pragmatica/peg/generator/ParserGeneratorTest.java

📚 Learning: 2025-12-30T12:39:57.084Z

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/main/java/org/pragmatica/peg/error/**/*.java : Support configurable error recovery with three strategies: NONE (fail immediately), BASIC (report error with context), ADVANCED (continue parsing and collect multiple errors)

Applied to files:

src/main/java/org/pragmatica/peg/generator/ParserGenerator.java
src/test/java/org/pragmatica/peg/generator/ParserGeneratorTest.java

📚 Learning: 2025-12-30T12:39:57.084Z

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/main/java/org/pragmatica/peg/parser/ParsingContext.java : Use packrat memoization for parsing performance optimization with configurable enable/disable

Applied to files:

src/main/java/org/pragmatica/peg/generator/ParserGenerator.java

📚 Learning: 2025-12-30T12:39:57.084Z

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/main/java/org/pragmatica/peg/error/Diagnostic.java : Implement Rust-style diagnostic formatting with error location (file:line:column), context lines, and help messages for error recovery output

Applied to files:

src/main/java/org/pragmatica/peg/generator/ParserGenerator.java
src/test/java/org/pragmatica/peg/generator/ParserGeneratorTest.java

📚 Learning: 2025-12-30T12:39:57.084Z

Learnt from: CR
Repo: siy/java-peglib PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-30T12:39:57.084Z
Learning: Applies to src/main/java/org/pragmatica/peg/tree/Trivia.java : Support trivia classification by content inspection: lines starting with // are LineComment, /* ... */ are BlockComment, otherwise Whitespace

Applied to files:

src/main/java/org/pragmatica/peg/generator/ParserGenerator.java

🧬 Code graph analysis (1)

src/test/java/org/pragmatica/peg/generator/ParserGeneratorTest.java (1)

src/main/java/org/pragmatica/peg/PegParser.java (1)

PegParser (26-158)

🔇 Additional comments (11)

src/test/java/org/pragmatica/peg/generator/ParserGeneratorTest.java (3)

350-380: LGTM! Effective test for furthest failure position tracking.

The test correctly verifies that AST parsers report errors at the furthest position reached during parsing (column 7 where '1' is encountered) rather than defaulting to 1:1 after backtracking.

382-407: LGTM! CST BASIC mode error reporting test is well-structured.

The test appropriately validates that CST parsers in BASIC mode report errors using the "line:column" format at the furthest failure position.

409-437: LGTM! ADVANCED mode diagnostic formatting test is comprehensive.

The test correctly exercises the ADVANCED error reporting mode with Rust-style diagnostics, verifying that formatted error messages include the furthest failure position.

src/main/java/org/pragmatica/peg/generator/ParserGenerator.java (8)

94-94: LGTM! Infinite recursion fix is well-implemented.

The inWhitespaceRuleGeneration flag correctly prevents infinite recursion when the whitespace rule uses the * quantifier. The flag is set appropriately around whitespace rule generation and checked before emitting skipWhitespace() calls in expression generation.

Also applies to: 101-101, 1117-1124

200-203: LGTM! AST parser furthest failure tracking is correctly implemented.

The tracking fields and trackFailure() method properly record the farthest position where parsing failed, and the parse() method correctly uses this information to report errors at the most informative location rather than after backtracking.

Also applies to: 220-223, 261-270, 290-293

1133-1133: LGTM! trackFailure() calls are consistently added to all AST match methods.

All terminal match methods now correctly call trackFailure() before returning failure, ensuring accurate error position tracking.

Also applies to: 1141-1141, 1146-1146, 1167-1167, 1182-1182, 1189-1189, 1202-1202

298-298: LGTM! Option API usage corrected.

The change from result.value.orElse(null) to result.value.or(null) aligns with the pragmatica-lite Option API.

1764-1765: LGTM! CST parser furthest failure tracking uses idiomatic Option types.

The CST implementation properly uses Option<SourceLocation> and Option<String> for furthest failure tracking, providing better type safety and clearer intent than the AST version's primitive fields.

Also applies to: 1790-1791, 1846-1854, 1900-1902, 1948-1951

1696-1696: LGTM! ParseResultWithDiagnostics correctly migrated to Option.

The migration from nullable CstNode to Option<CstNode> is complete and consistent across factory methods, helper methods, and call sites, improving type safety per JBCT compliance requirements.

Also applies to: 1700-1706, 1708-1717

3064-3064: LGTM! trackFailure() calls consistently added to all CST match methods.

All CST terminal match methods now correctly call trackFailure() before returning failure, and the methods are appropriately available in both BASIC and ADVANCED error reporting modes.

Also applies to: 3073-3073, 3078-3078, 3101-3101, 3121-3121, 3129-3129, 3145-3145

474-477: LGTM! Conditional skipWhitespace() calls prevent infinite recursion.

The conditional skipWhitespace() calls based on inWhitespaceRuleGeneration are consistently applied across all relevant expression types, properly preventing infinite recursion when the whitespace rule itself contains repetition operators.

Also applies to: 684-687, 743-746, 862-867

siy · 2025-12-31T10:29:22Z

Re: Nitpick - Temporary directory cleanup

Rejected with justification:

OS cleanup is sufficient - Test temp directories are small (~10KB each) and automatically cleaned on reboot
Design constraint - @TempDir requires a field, which doesn't fit the helper method pattern used across multiple test files (GeneratedParserTriviaTest, GeneratedParserDiagnosticsTest)
Minimal impact - Tests run infrequently; accumulation is not a practical concern
Consistency - Same pattern used in existing tests without issues

The suggestion is valid but the cost/benefit doesn't justify the change.

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

coderabbitai bot reviewed Dec 31, 2025

View reviewed changes

siy and others added 3 commits December 31, 2025 13:52

feat: sync Java 25 grammar improvements from jbct-cli

07ce956

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

fix: use furthest failure position for "unexpected input" errors

c3814aa

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

chore: prepare release 0.1.8

e683ec9

siy changed the title ~~fix: report parse errors at farthest failure position~~ chore: release 0.1.8 Dec 31, 2025

siy merged commit a3e70b9 into main Dec 31, 2025
2 checks passed

siy deleted the fix/farthest-failure-tracking branch December 31, 2025 13:46

coderabbitai bot mentioned this pull request Jan 9, 2026

chore: release 0.1.9 #10

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: release 0.1.8#9

chore: release 0.1.8#9
siy merged 4 commits intomainfrom
fix/farthest-failure-tracking

siy commented Dec 31, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Dec 31, 2025 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

coderabbitai bot left a comment

Uh oh!

siy commented Dec 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

siy commented Dec 31, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Problem

Solution

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Poem

Pre-merge checks

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

siy commented Dec 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

siy commented Dec 31, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 31, 2025 •

edited

Loading